I thought it will be nice to share some code-review experience from time to time. A code-review is important and necessary for PR (Pull Requests) to merge to the development/release branch. But sometimes, a minimal 2 reviewers are not sufficient e.g. once, a PR with irrelevant change has been merged to development branch even with 2 reviewers ‘Approved’. Later… these reviewers were ‘punished’ by bringing in donuts!
The feeling when you care so much to not break something and then you find out later that the value is not used. PS: It is strange that the Resharper has not identified these as useless code.
You may also like: [坑爹的代码] – 变量未使用
–EOF (The Ultimate Computing & Technology Blog) —
GD Star Rating
loading...
259 wordsloading...
Last Post: Technically Images can be Stored on BlockChain
Next Post: How to Retrieve SteemIt Account Information via API steemit/account?